Problems with AMR Addon and “identical” items


#1

Hello,

There is two small bugs that I found using the AMR addon and “identical” items.

First problem, for Windwalker I have two of the same 1H weapons with different ILevels. Almost every time switching from say Mistwalker to Windwalker using the addon it will equip the 1H weapons in the wrong slot (high ilevel in off-hand, low ilevel in main-hand). If I press “Activate Wind Spec and Equip Gear” one more time it frequently gets it right on the 2nd try (but not always).

Second problem, once again caused by items with the same name. I have two identical azerite shoulder pieces but with different traits. Switching specs using the addon will once again mix up the items and equip the wrong one. In this case it just always picks the wrong one (probabily whichever one comes first in the bags).

In both cases the game itself can tell which shoulders are which, when using Equipment Manager sets it will always equip the correct gear. On the website, everything is showing up fine and it knows I have 2 identical items (because it suggests different traits for each spec). Is there anything you could do to get this to work in the addon as well?

Thanks,

Stef


#2

If you want to experiment with my sets https://www.askmrrobot.com/optimizer#us/zul’jin/ripjaws

$69;US;Zul’jin;Ripjaws;Hoax;1;2;120;35;13:113,15:1,12:73,8:150,4:93;3;.s1;16;1113121;.s2;17;1313111;.s3;18;1123132;.q1;157942s5b1562b3213b363b245a280429a-12764a772a-4459;133s2b-3843b3389b1b6;243s11b-3384b3234b224e5945;988s7b-3458b3234b224;320s13b-3488b3258b3;992s10b-4740b1464b3279b14;34s14b-3293b3279b14;65s6b-3283b3267b15;1827s12b-3257b3241b225e-5;329s16b-3486b3263;436s9b-3223b3224b339;123s3b-3563b3213b350b15b242a14591a-10886a911a-4616;3s1b-3820b3213b350b11b245a11997a-8093a555a-4459;3s8b-3804b3207b341;3326s15b-3623b3284b340;.q2;157914s7b1562b3224b17;161s2b-3263b3389b1b6;245s13b-3424b3267b7;46s11b-3274b3267b7b16x154128e5940;761s14;212s3b-3260b3233b11b274a273823a-5944a721a-4622;1282s9b-3583b331b2978b12x0e30;96s6b-3281b3267b15;739s5b-3307b3283b11b334a9350a-5439a-3927a16;1088s12b-3578b3241b225e-30;816s15b-4967b1521b3224b340;75s1b-3564b3213b350b11b245a11997a-8093a555a-4459;2s10b-3819b3224b340e-3;1s8b-3549b3207b341;431s16b-3563b3224b339e9;7s17b-3593b3254b339;.q3;158075s2b1540b3389b1b6;243s11b-3384b3234b224e5945;807s13;181s7b-3458b3234b224;1312s10b-4967b1464b3279b14;1s5b-3308b3283b11b37a280555a-16571a4453a-4459;2s9b-3346b331b2978b12x154128e25;2s1b-3306b3283b11b37a15940a-19a-15937a16;23s12b-3331b316b2978b13x0e-25;6s14b-3292b3279b14;30s16b-3303b3286b16e17;0s17b-3322b3309b12e3;35s6b-3281b3267b15;2715s3b-3237b3213b11b339b275a23077a-22947a4486a-4616;6s8b-3823b3207b341;3326s15b-3623b3284b340;.inv;2459;130;3;835;879;32;74;226;437;1143;445;0;285;4091;801;2416;4011;15203;5212;11033;5406;17867;13155;24417;5708;147;7698;0;2;1;8;313;2;1;3407;1090b733b756b1b8x153459y-10942z9543p1528p2000p45q-2076q1839q237r-2086r2041r83;1b-766b762b4b2x-9y10z3794p-2139p2056p82q-2123q2041q83r-2119r1844r274;2b-766b766b1b1x-18490y18490z-3796p-2060p1787p199q-2039q2031q83r-2119r1844r275;8702;0;844;2;239;1;1;1463;1413;47;465;1792v33b2126;3798;162;3697;1;1;944;0;1;28;0;0;0;0;1;0;0;1;1;1;1;0;1;0;0;0;0;0;0;0;0;1;1;27;0;1;0;2;52;0;7;1;29;0;207;0;0;1;0;1;0;173;0;0;1;76;61;514;2;0;2;414;1;0;1;1;1;1;4;35;1;0;0;0;557;0;0;0;0;0;159;0;1;1;2;0;1;0;0;1;1;0;3;0;0;6;0;0;1;0;1;0;0;699;3;237;24b-2086b3244b224;1895;87;34b-3448b3576b245;7b-3821b3224b17;29b-3241b3224b17;1b-3241b3578b242;27b-3820b3213b363b245a280429a-12764a772a-4459;378b-3871b3267b7;46b-3274b3267b7b16x2069e5940;9b-4762b1512b3231b227;3;393;78;13;1;2;262;212b-3468b3233b11b274a9845a-5944a721a-4622;8b-3518b3241b225;121;149b-3496b3267b7;9b-3264b3258b3;130;31;104b-3097b3241;68;100;0;0;239;100;1;0;1;0;79;141b-3435b3283b11b37a16577a-14375a2419a-4621;4b-4782b1456b3286b16;0b-3307b3294b13;1b-3307b3294b13;19b-3307b3294b13;1b-4757b1450b3294b13e5;9b-4758b1451b3294b13;51;4;0;1;0;1;1;0;17b-3307b316b2978b13x0;0b-4759b1462b3281b16;727b-3307b3283b11b334a9350a-5439a-3927a16;223b-3573b3239b281b62;781;0;1;0;0;83b-3587b3241b225e-5;329b-3486b3263;105;58;273b-3223b3224b339;51b-3563b3224b340;0b-5085b1521b3224b340;72b-3564b3213b350b15b242a14591a-10886a911a-4616;0b-3820b3213b350b15b242a14591a-10886a911a-4616;3b-3820b3213b350b11b245a11997a-8093a555a-4459;2b-3819b3224b340e-3;33;6;7;121;87;9;1;81;2;0;12;73b-3564b3224b339e9;7b-3593b3254b339;493;2075;360;0$


#3

When swapping gear, it does check the azerite traits… we put in some tweaks in the last addon update to improve on that – in theory it searches for the best-matching azerite item (where the chosen traits on the item best match the desired traits in the optimized setup). I’ll see if I can create a test case where it doesn’t work as expected. Do you have the desired traits already chosen on both items? Or do you still have to choose the traits on one of the items?

For the weapons… it should try to match the bonus IDs… I’ll see if I can get two of the same weapon on one of my characters and try it out.

The super annoying thing about the equipment manager: we can’t create an equipment manager set until we equip all of the desired gear in each slot… so no matter what, we have to write our own code to reliably equip a set of gear. But the in-game addon API is really terrible for searching and swapping items. (Also, the in-game addon API for getting the item level of an item returns the wrong value a lot of the time.)


#4

The traits are already all chosen. I could try to have a look at it myself I guess. Which files do I need to check for the swapping logic Gear.lua?


#5

Something else I found weird, the item which has Fury of Xuen, shows up in the “shopping list” as not having Fury of Xuen, could that be because the spellId is wrong or something? And that could be the reason why these shoulders are not equipped. For example, if it ends up just falling back to the next best one which would end up being the Brewmaster shoulders because they both have the same traits for rings 2-4?


#6

Another weird behavior I found is with the “Equipped” flag of items. It looks like when the 3rd ring power is not specified by BiS on the website (because it doesn’t have any impact on DPS) the item will never show as fully equipped in the addon. That is maybe another reason the wrong shoulders are picked.


#7

Yeah could be… I think it adds another bonus ID to the item… I’ll play around with it.


#8

Looking around the code the 1st thing I notice is when it does scanBagForItem it decodes the itemlink for the bag item using Amr.ParseItemLink the resulting item has no azerite traits (bagItem.azerite is not set). I don’t know if there is another check later on that actually compares the items correctly.


#9

The item link does not contain azerite information – it has to be read separately.


#10

I posted an addon update that should resolve these issues. If you continue to have a problem, post in this thread:


#11