Best-In-Slot is considering Warbound/BOP items when the exclude option is checked. Snapshot ID: f16e678249784e75aadc5f3776fed238
I’m assuming that you mean Best in Bags? I don’t see the exclude warbound option chosen in your Best in Slot settings.
Which particular items and for which of your three setups are you referring to?
Yes, sorry. Right now it is showing Warbound items for both trinkets. I’m including a screenshot of the settings I’m looking at with an updated Snapshot ID: 1cbab1c1342045139345ed9ea8da0ee4
Those items are showing as Bind on Pickup on our site… which means the data from the addon is indicating that they are soulbound to you. Which version of the in-game addon are you using? It shows in small text at the bottom of the in-game addon window when it opens.
v157. I have also uninstalled and reinstalled the add-on.
So we use two API functions in-game to determine if an item is warbound until equipped or soulbound:
warbound: C_Item.IsBoundToAccountUntilEquip
soulbound: C_Item.IsBound
Both of those are returning false for e.g. the higher item level garbagemancer’s last resort… and the game data indicates that it is a bind on pickup item, and no provided bonus is modifying it to a bind on equip item…
I’d have to get a few more test cases… I’m hesitant to just go and say any item where those two functions return false is bind on account…
I’m curious why the first function (IsBoundToAccountUntilEquip) is not returning true… if there is some in-game situation where that method is not functioning properly perhaps. Could you try going to the bank in town and opening up your warband bank again, then export to our site – does it update at all?
New snapshot is ecb55f0990b7403f9ab31ea7bfca3bc6. It did return without Warbound items but looking at the Blood setup doesn’t pull in a weapon. It shows the equipped as having a Warbound item but in game it shows as Soulbound.
That’s weird… do you actually own two identical Arathi Crusader’s Halberd items in-game? Just making sure it’s not picking up a duplicate item for some reason.
I do. One is Soulbound and the other is Warbound and both are the same item level and no bonus stats.
On another note, I was able to replicate the issue with it wanting to use Warbound items. After using the best in bags for another character trying to replicated the issue by turning off and on the exclude feature, I put the original character back in and the results showed even worse Warbound/BOE suggestions. Snapshot: fc365d63e4bd4909bfd8c658520055d3
If you are optimizing different characters, they won’t impact each other – all data is saved separately for each of your characters.
In this case the data that our website is receiving from the game seems inconsistent… I’ll have to try and replicate it in-game on one of my own characters, see if perhaps they changed how those functions work for determining if an item is warbound. I’m assuming these items show “warbound until equipped” on them in-game?
Yes, the items do show “warbound until equipped”.
Another question for you – and thanks for your patience working with me to figure this one out!
Are the items that are getting improperly flagged as warbound (or not warbound) in your warband bank, in your bags, equipped on your character, or all of the above?
I’m happy to help.
The are mostly in my warbound bank but a couple are in my bags. I double checked and they all show “Warbound until equipped”.
I managed to get another couple friends to try out the addon and check if their warbound gear was getting read correctly, and I was still unable to replicate this issue.
Later today I’m going to do a server update that should work around this issue for now… hopefully it does not create any unintended side effects, but it seems like a pretty safe change. We’ll keep an eye on it. You will need to re-import your gear from the addon after the update for the change to take effect.