sample profile used: Not Available
-Maelstrom cap is still 150 instead of 100. The maelstrom cap is on our spec passive (effect#6, base is 100, effect is now +0 instead of +50 in legion)
-Stormbringer isn’t adding the “2nd cast” (stormstrike goes on full CD immediately instead of a 0 CD stormstrike)
-Strength of Earth and Feral Lunge ARE on the spec passive in spell data, but AMR does not have it whitelisted. (feral lunge obviously not as big a deal, but SoE is way stronger than it should be)
-Molten Weapon dot IS NOT on the spec passive in spell data, but AMR has it whitelisted and it shouldn’t be.
-Lightning Conduit and Lightning Shield defense procs ARE on our mastery in spell data, but ARM does not have it whitelisted. (assuming LC is not implemented yet, LS defense proc not a big deal)
-Speaking of Mastery, didn’t stop to manually calculate, but it appears as though the mastery data is whitelist modifying abilities, then further increasing all frost and nature spell school damage? I could just be mis-interpeting this. https://i.imgur.com/9AYpV88.png. Mastery should only be affecting abilities explicitly on the aura now, zero school modifiers.
-Doomhammer artifact import from armory is real wonky (imported an ilvl 258 doomhammer and the result was a ~390 ilvl mainhand and a ~160 offhand) (probably not a big deal with legion stuff going away)
-Feral Spirits with Elemental Spirits still has a 120s CD instead of being reduced to 90s.
-Lava Lash not affected by flat fire buff from molten weapon (fire dog with elemental spirits). Fire buff should also be multiplicative, but the dot damage should be additive (70% dot with 2 stacks)
-Crackling Surge not affecting wind strike (don’t see it in the buff definition for crackling surge). While Elemental Spirits and Ascendance are on the same talent tier and typically incompatible (barring legion gloves), the spell data for Crackling Surge affects both - if some ascendance proc like the gloves comes back this may come back to bite you.
-Crackling Surge seems to be applying 2 seperate buffs instead of stacking to 2 like icy edge and molten weapon are. They all apply seperate buffs in game, but its more intuitive if its just a stacking thing in the report - this is just a weird reporting gripe https://i.imgur.com/qq6LyOT.png. Also seeing the stack counts seperately (% of time at 1 and 2 stacks) would be nice instead of just overall uptime of any stacks.
-Earthen Spike debuff not increasing the damage of Sundering (flamestrike damage still counts as physical for the dmg taken mod).
-I see in your elemental spirits ability definition comment you have “TODO: Only auto attacks are proc’ing Icy Edge Right now. Bug?”, icy edge does only proc off white attacks - the original implementation made it so your wolves proc’d the icy edge attack when you auto attacked, they simplified the ability to just be the player procs the attack on white attacks instead, its far more likely that the tooltip is just very misleading and very wrong.
-Spellpower not listed in the stats panel (nor the composite attack power or what you guys call ‘ability damage’, but to be fair simc hasn’t overhauled the stats table either to show composite attack power). Since Spellpower is no longer 100% of attack power, it should be listed as a stat.
-Gale-force striking appears to be stacking its intensity and doing odd things with its buff apply / refresh logic, none of the new weapon enchants stack in-game https://i.imgur.com/iGhKTKG.png ~1.3 swing speed is way too fast (2.6 / 1.1 / 1.35 / 1.35 = ~1.3) - https://i.imgur.com/2Y53602.png
-Vile Bile (weapon proc from Bile-Stained Crawg Tusks) is not refreshing its duration back to 9s on buff stacking https://i.imgur.com/16vbZgY.png
-Some Enhance specific Azerite traits appear unimplemented (Primal Primer, Roiling Storm, Lightning Conduit). Striker’s Grace, Storm’s Eye and Electropotence have yet to be found ingame so personally I wouldn’t bother with those. Didn’t mess with the shared elemental ones yet.
-The Stormstrike that triggers the 20th (and 21st) stacks of Lightning Shield should apply 1 Lightning Shield damage event, current AMR is applying zero. Basically the main hand SS hit brings you to 20 stacks, you gain the overcharge buff, then the off hand lands with the buff up and applies one damage event. With a defensive proc bringing you to 18 stacks, if you SS and go to 20 there should be zero damage events (as the overcharge hit is evaluated before the LS buff gains a stack). (It used to inconsistently proc 1 or 2 damage events but this has been recently fixed and I’ve yet to update it in simcraft myself)
-obvious rotation improvements, I imagine optimization is last after bug fixing for you guys.
Stopped after this point, let me know when these get knocked out and I’ll go dig for more. It gets to a point where when enough things don’t line up that it’s difficult to look for others.