I’m wondering if the sim is accounting for the set bonus on void reaper’s warp blade + void reaper’s contract – in my BiB it isn’t selected for Havoc but is for Veng. I would totally believe that it’s just not that great, but wanted to check. And if there’s a way that I could check myself for any future similar items, would love to know that too!
82892778b94640f9a3996082972c6a73
I’ll take a look and make sure that the set bonus is being activated – it’s a pretty tricky one to implement, but I just ran a couple tests and it appears to be working (the code is a bit slow for it so I’ll speed that up, but it is activating).
That said, the set bonus is pretty small and it’s quite possible it wouldn’t be big enough to warrant using the trinket with the weapon or vice versa in many cases.
The effect on Void Reaper’s Contract is a pretty standard damage effect, which gets a 50% boost on targets below 35% health (summons 2 extra phantoms that hit for 25% of the main effect).
The last 35% of a fight is usually not quite 35% of the fight length due to several specs having execute effects, so we can ballpark that ~30% of the time you’ll get a 50% bonus to the damage of the trinket effect.
With the set bonus, you can get this 50% bonus whenever the DoT from the weapon is on a target. That DoT is 2 rppm (hasted) and lasts 10 sec. If we are generous for a moment and say that you average 50% haste over a fight, we can estimate roughly a 50% uptime on this DoT.
So you were already getting the extra phantoms for 30% of the fight. Now you are getting them for 50% of the other 70%, so about an extra 35% of the time you’ll get the phantoms, or in total including execute range the phantoms will trigger about 65% of the time
As said above, the phantoms increase the damage effect by 50%, so if you math that out, the set bonus ends up being about a 15.2% improvement (65% of triggers get the phantoms vs. 30% of triggers without the set bonus, or a 32.5% avg increase to the base proc with the set bonus, vs. a 15% avg increase to the base proc without).
I doubt that would be worth more than about a 0.5% DPS increase in most cases.