Bug Report - Item Upgrades

This is showing that an upgrade for me would be weathered stormfront vest but I am already wearing 2 embellished items, I cannot wear another?

Here is my export:

$165;EU;Kazzak;Swatto;The Fridge Raiders;1;2;80;12:1,13:1,4:17;1;.s1;4;11111111111000111120101110111211102001001100111101101101000010121000102000100100100000101010110100001100111101022110100_34;.s2;5;111010112010011010121100110002110120101100011100121011201000101111101011100112001110111000001001010100001101012110010_35;.q1;185780s17b6652b3370b233b129b6b1965d1e7439!D46C0D5A2;4872s13b-5703b3364b239b128b7b1907d1!D3ED907ED;28682s9b-3506b111b58b667b6b788b688b941b3b868j49k36l8d1e-42!D469CABB4;1802s11b-9719b3450b3603b128b7b6b483b1476d1x213461y0e73!D473B09AC;64s12b-9153b3450b3603b128b7b6b483b1476d1x6y12e0!D4666140C;1241s16b-3564b111b58b667b6b788b879b750b3j40k32l8d1e-31!D468681C8;13058s15b-2160b2364b144d1x24565e-24!D35458CD6;2190s3b-10881b5132b3603b135b1843b122b320d1!D472BDA3B;1s7b-11142b5119b3603b135b1842b129b315d1e186!D465D981E;1s1b-11156b5132b3603b135b1841b124b321b245d1!D466B4604;1s10b-11401b5132b3603b100b1875b125b320d1!D46CBC151;8272s6b-11186b11044d1h1241246x-24553!D1A5832B7;309s5b-5881b3361b242b128b7b1849b114d1c1e-237!D47AEE411;1s8b-10794b5093b3603b128b7b1849b116d1c1e54!D46C7D75E;70s14b-10769b5066b3603b128b7b1968d1!D48A39C33;5665s2b-12318b1519b8696b128b7b6b483b1476d1x252y-282!D4665FA84;.q2;178824s11b41b9978b236b128b7b6b483b1476d1x213455y0e7340!D46688FAB;6956s17b-5703b3370b233b129b6b1965d1e99!D46C0D5A2;6s5b-5703b3364b239b128b7b1849b114d1c1e-75!D4733B140;33526s14b-9151b3450b3603b128b7b1965d1!D473B05D5;22s9b-3564b111b58b667b6b788b688b941b3b868j49k36l8d1e33!D469CABB4;1802s12b-9719b3450b3603b128b7b6b483b1476d1x6y0e73!D473B09AC;1305s16b-3564b111b58b667b6b788b879b750b3j40k32l8d1e-31!D468681C8;13058s15b-2160b2364b144d1x24583e-24!D35458CD6;2190s3b-10881b5132b3603b135b1843b122b320d1!D472BDA3B;1s7b-11142b5119b3603b135b1842b129b315d1e186!D465D981E;1s1b-11156b5132b3603b135b1841b124b321b245d1!D466B4604;1s10b-11401b5132b3603b100b1875b125b320d1!D46CBC151;8272s6b-11186b11044d1h1241246x-24553!D1A5832B7;316s8b-5881b3370b233b128b7b1849b116d1c1e-177!D46FEDEC3;64s13b-10776b5073b3603b128b7b1966d1!D48A39C33;5536s2b-10797b5093b3603b128b7b2b3b1960d1!D46F5069E;.tal;4~75627811~FS - Mythic+/Cleave Low Mover~11111111111000111120101100111211102001001100111101101101000010121000102000100100100000101010110100001100010101022110100_34;4~83058014~AR~11111111111010111120101100111211100101001100111101101101000010121000102000100100110111000001001001010001000011022110010_35;5~74826869~M+~111010112010011000121100110002110120101100011100121011201000101111101011100112001110111000001001010100001000012110010_35;.inv;5512!D48CA17E1;1436d1!D3538DA26;120881b719b803d1x151289y4563z-18310p1472p1865p81q-1946q1864q275r-2138r1863r200!D0B51F8EB;1003b-801b801d1x3726y10757z7p-2064p2056p45q-2101q1864q275r-2139r2056r82!D0B51F8EC;4923d1!D0B51F8EE;3887d1!0029240AB;20433b31b3379b1b1383d1!D0B51F8EF;11148b-4844b4814d1!D0B51F8F0;9596b366b3354b249b128b7b1849b112d1c1!D47FC9E66;4b-5699b3358b245b128b7b1849b113b569d1c1!D46688D22;0b-6269b3358b245b128b7b1849b113b569d1c1!D46E3E945;1b-12880b9978b236b128b7b6b483b1476d1x61423y0e7340!D46688FAB;6962b-5703b3364b239b128b7b1849b114d1c1e24!D4733B140;15b-5701b3361b242b128b7b1849b113d1c1!D4755028E;8b-12311b9972b242b128b7b1849b113b569d1c1!D46724D93;4b-6269b3370b233b128b7b2b2b1961d1!D47B2C5A7;6b-12313b9967b246b129b6b1961d1!D46FED915;5b-5699b3344b259b129b831b1076d5!003421093;5134b-5639b3364b239b128b7b1963d1!D47454BD2;19856d1!D0B51F901;203b-9119b3418b3602b2020b647d1!D472882A7;21b-9687b3418b3602b2020d1!D4750F953;0b-9011b3389b3603b1984b52d1c1!D472D40F2;1227!D4816362B;18!D46DA8410;7025b-9115b3476b3603b128b7b1986d1!D1DDD24F1;0b-9180b3456b3603b128b7b1963d1!D4873E7C2;4b-9151b3450b3603b128b7b1965d1!D473B05D5;5b-9172b3469b3603b128b6b1904d1!D37B4DF28;38b-10717b5076b3603b960b1068d5!D472D389E;1789b-9090b3459b3603b129b6b1962d1!D47B86446;13b-9159b3459b3603b128b7b1849b113b569d1c1!D47CFEDCA;6b-9735b3466b3603b128b7b1849b111b571d1c1!D471DCFDC;1565!D233F5454;394d1!D48B08BDD;950d1!D47232CC7;35!D3C9E6E6D;0!D3C9E6FAE;0!D3C9E6F38;0!0031913B9;0!0031913BC;2024d1!D478A1808;1d1!D478904F6;5624d1!D48B4E735;12d1!D48B4E734;2723b-11371b5102b3603b129b6b1962d1!D4697A15F;6b-10815b5115b3603b128b832b1024b53d5!D48C17E4A;1b-10749b5109b3603b128b7b1849b111b571d1c1!D4858FE50;0b-11375b5106b3603b128b7b1849b112b570d1c1!D48793DA1;0b-11371b5102b3603b128b7b1849b113b569d1c1!D472640A3;1b-11378b5109b3603b128b7b1849b111b571d1c1!D4852F0CC;0b-11371b5102b3603b128b7b1849b113b569d1c1!D47226913;0b-11375b5106b3603b128b7b1849b112b570d1c1!D46DDE22B;0b-12881b1510b8705b128b7b1849b113b569d1c1!D473EC0C0;0b-12878b1503b8709b128b7b1849b112b570d1c1!D4800B177;0b-11378b5109b3603b128b7b1849b111b571d1c1!D48102402;3058b-11407b5138b3603b100b1884b114b568d1c1!D4683CD22;399b-6269b3273b330b138b2b1902d1!D4674C1C7;19b-5645b3226b377b1984b51d1c1!D478B44FA;1b-5638b3229b374b1984b52b630d1c1!D478900A4;0b-6269b3196b407b1984b44b638d1c1!D46735732;2b-6269b3236b367b1984b54d1c1!D4680C6F9;1b-5641b3229b374b1984b52b630d1c1!D46757173;63d1!D3544FD68;3d1!D3544ECC9;1d1!D35450281;344b-11378b5109b3603b960b1068d5!D4750F959;752d1!002B2E46F;1787d1!D48A3E2B5;1d1!D48A3C8DE;1543b-9090b3459b3603b128b7b1849b113d1c1!D475F760A;22b-12311b3155b7059b128b7b1963d1!D469BDDC9;372b-10807b5106b3603b2036d1!D4750FF15;665b-9094b3455b3603b2027d1!D48B4BECD;661d1!D47288590;1317d1!D46CC573A;770b-5630b3370b233b128b7b1849b116d1c1e60!D46FEDEC3;1b-5703b3364b239b128b7b3b1b1959d1!D46724F1F;63b-10777b5076b3603b128b7b1963d1!D47FC909C;427d1!D46735735;54b-10807b5106b3603b2036d1!D472887ED;120b-10774b5135b3602b2020d1!D47007E63;1810d1!D48B08D92;3125b-10715b5093b3603b128b7b2b3b1960d1!D46F5069E;.gv;.hlv;0|710|723;1|710|710;2|710|710;3|704|710;4|704|720;5|723|723;6|710|710;7|720|720;8|710|710;9|710|710;10|710|710;11|730|730;12|0|723;13|60|694;14|720|720;15|710|710;16|10|710;.ach;41886;41887;41888$

So there are a couple of things increasing the ranking of that item – the first is the set bonus prediction option. If you turn that off, its ranking will go down because it’s not trying to estimate it as if the bonus is active.

And yes – with your current gear you can’t equip another embellished item. You would have to swap one out for it. (Really, you would probably swap two out and activate the 2-piece bonus.)

But… we decided it would be annoying to just say “sorry, can’t rank this item at all because you have two embellished items equipped already.” So we go ahead and try to give it a reasonable ranking despite the constraint.

Quick Rank is a fast ranking method that won’t examine tons of gear combinations, making it not quite as good for difficult cases like this one. The other searches like great vault, catalyst, etc. are much slower but try a lot more combinations (Quick Rank has to be able to rank potentially hundreds or even close to a thousand items, whereas those other searches are usually 50 or less).

In this case you could try adding those crafted items using “Add to my Bag”, which will then try the item with a bunch of combinations of your existing gear.

Our goal moving towards the end of this expansion and into the next one is to close the gap between the Upgrade Finder searches and make “Quick Rank” nearly as thorough as the other rankings, but it requires some speed improvements to the core optimizer, which we are working on!

The Upgrade Finder in general is a more difficult feature to write than it seems… there are a lot of different ways to think about how an item should be ranked, mostly stemming from the question: how far do I want to plan ahead? We’ll be giving some more thought to this as we continue to make improvements.

Thanks very much for the quick response, I have loads of people telling me to use raidbots but I like the simplicity of AMR.

I like messing around with simulations from time to time, but I’m with you on the simplicity. (Also… some people play tanks and healers too, and simulationcraft is a mostly DPS-focused project.)

One thing I like to point out to people is just how many combinations of gear there are… for the sake of argument, let’s say you were able to narrow it down to just 2 item choices per slot, and we’ll say 4 unique choices for rings and trinkets. That’s around 300,000 combinations of gear. If you up it to just 3 item choices per slot, it’s around 50 million combinations of gear.

Last I checked, the most expensive raidbots plan lets you do about 1600 combinations in a single top gear run. That’s… not very many combinations – you more or less need to know the answer already before you start! Not to mention it takes a long time to run.

This isn’t to say that simulation isn’t useful… it’s just very slow and expensive when you try to do a full gear optimization with it.

In comparison, our optimizer can start from any amount of gear in your bags (or from every available item with best in slot), and behind the scenes it will filter out gear that is highly unlikely to be chosen as optimal automatically. (On raidbots you have to manually choose each item that you wish to examine.)

Our resulting set of gear after this filtering is much larger than anything simulationcraft could reasonably support – you will usually have a few billion or trillion combinations still available. Then we run optimization algorithms that can sift through the remaining combinations very quickly – even with a fast approach like ours you cannot actually calculate the value of a trillion sets of gear in a few seconds. You need to be smart and pick a subset of those combinations that is extremely likely to contain the best overall combination.

That subset is still very large compared to what would be viable with simulationcraft – how many full sets of gear actually get scored can vary quite a bit based on your input, but at a minimum it is in the hundreds of thousands for most cases, and often much more. And this is all in a couple of seconds.

Bottom line – we like to take the approach of examining a lot of sets of gear very quickly – otherwise the user has to arrive at our site with most of the answer already figured out… which kind of defeats the purpose of a gear optimizer!